suggest to use URL constructor in pg-pool readme#3073
Open
komachi wants to merge 1 commit intobrianc:masterfrom
Open
suggest to use URL constructor in pg-pool readme#3073komachi wants to merge 1 commit intobrianc:masterfrom
komachi wants to merge 1 commit intobrianc:masterfrom
Conversation
…age, use URL construstor
Collaborator
|
I’m not sure why this is documented this way in the first place instead of using the |
|
Is there a way to extend the client for pooled connections? I need to use a schema, but the existing type definitions does not accept a schema, unless I pass it in as a part of the URL in the client. However, it's not extensible to pooled connections. So this is fine for client - And I was thinking maybe if there was a provision to do something like this - wherein the URL will get deconstructed on it's own (overly hopeful, I know) where the additional parameters get attached to the Pool object. |
Collaborator
|
@usahai As I mentioned in the previous comment, use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improve example with parsing connection string for pg-pool, use URL constructor, available since node 10
https://developer.mozilla.org/en-US/docs/Web/API/URL/URL